n72.75
Move slow and try not to break too much.
Orbiter Contributor
Addon Developer
Tutorial Publisher
Donator
- Joined
- Mar 21, 2008
- Messages
- 2,696
- Reaction score
- 1,353
- Points
- 128
- Location
- Saco, ME
- Website
- mwhume.space
- Preferred Pronouns
- he/him
I have two small suggestions for the Orbitersim organization on GitHub, that I think will make workflow a bit easier/safer.
I can only speak from my experience with NASSP (and being a fly-on-the-wall to [open]simh and the pdp10 organization), but it works quite well.
You can look through the closed NASSP PRs https://github.com/orbiternassp/NASSP/pulls?q=is:pr+is:closed , and see who was a reviewer, comments, issues, milestones, etc.
The PDP-10 organization has this for members: https://github.com/PDP-10/-READ--THIS-
- Add regular contributors as "members" (not Owners), to the Orbitersim organization. There is no limit to the number of members that can be in a GitHub organization, so no issue there. Right now people who aren't members can't: request reviewers to pull-requests, add labels (bug, enhancement, etc) to issues or pull requests, review or approve pull requests.
- Protect the main branch so that no one (not even "Owners") can commit directly to it or merge pull-requests into it without an someone approving a pull-request. We've been very good about checking each others code. This shouldn't really add any extra work, but it adds a lot of safety.
I can only speak from my experience with NASSP (and being a fly-on-the-wall to [open]simh and the pdp10 organization), but it works quite well.
You can look through the closed NASSP PRs https://github.com/orbiternassp/NASSP/pulls?q=is:pr+is:closed , and see who was a reviewer, comments, issues, milestones, etc.
The PDP-10 organization has this for members: https://github.com/PDP-10/-READ--THIS-