- Mar 31, 2008
- Reaction score
That is excellent news! Maybe you want to go through the CMakeLists.txt files in the sound directory, just to make sure I didn't miss anything that needs to be built or deployed. Regarding the VS project and solution files - these are strictly speaking no longer necessary with the cmake files. I don't know if you want to keep them in for people who want to build XR sound without cmake, but then both build systems will have to be kept up to date. Once you are happy with the branch we can merge it into main to get rid of the CTDs you mention.Good news here @martins! I believe what happened before was that I was in the wrong Orbiter folder on my local system -- on the second test, I believe I was in my old cloned repo folder that was not a clean fetch, but was just an update of the previous Orbiter repository folder (sorry about that!). Tonight I did a clean repo clone to a new folder, and XRSound builds (and works!) as part of the Orbiter build now! Nice work!
I think this is thanks to a DarkWanderer pull request. Open source community at work!One side note for all -- I was getting a CTD on orbiter_ng.exe startup 50% of the time from the trigger_sound_build_cmake branch (which was forked off an older version of main), and after tracing the cause, it turns out that intermittent startup CTD as well as the rest of the x64 pointer truncation warnings are already fixed in the main branch. So if anyone is running an older version of main, you will want to pull the latest main branch changes to fix that potential CTD on startup.