Problems with building orbiter because of irrKlang

[Gondos]

Thanks, but don't bother yourself if it's not trivial to do it properly. I'll take a look if it's possible to do it on my side but if it requires modifying the .github folder, I don't see how it can be made locally without ending up in the PR.

 

[Gondos]

With the release of SDL 3.4.0, I did some more tests and there are nasty clicking sounds whenever a sound starts or stops. irrKlang has some when a sound stops but nowhere near the level I get from SDL3_mixer. Messing with fadein does not help much (it needs more than 250ms to have some effect and it does not work on stops) and there's not much in the API to try to work around the problem. Not sure where that leaves us but I feel that SDL3_mixer is a no-go...
I'll toy with other libraries and see if I can find something better.

 

[Gondos]

Got more luck with miniaudio, managed to virtually eliminate all poppings on my hardware. Sounds almost weird after years of hearing a click when releasing the + key

 

[Gondos]

There's a build using miniaudio available on github : https://github.com/TheGondos/orbiter/actions/runs/20669676993
You can take the XRSound.dll file from the Modules/Plugin directory and copy it to an existing Orbiter2024/Orbiter2016 installation if you don't want to create a new one (you'll need the XRSound directory too if it was not previously installed).
No additional dependency necessary.
The PR is here: https://github.com/orbitersim/orbiter/pull/627

 

[misha.physics]

I tried the XRSound.dll with my Orbiter 2024 installation and I can confirm - poppings disappear. Amazing!!!

But now I start to hear the poppings after releasing the "+" key with my Cirrus-SR22 add-on that uses a custom engine sound.

And vice versa until the XRSound.dll is replaced I hear the poppings with DG and I don't hear them with my Cirrus-SR22.

 

[misha.physics]

The bahaviour of the default Atlantis is the same as with DG, namely I hear poppings until the XRSound.dll is replaced and I don't hear them if I replaced the XRSound.dll with your one.

 

[Gondos]

I tried the XRSound.dll with my Orbiter 2024 installation and I can confirm - poppings disappear. Amazing!!!

But now I start to hear the poppings after releasing the "+" key with my Cirrus-SR22 add-on that uses a custom engine sound.

And vice versa until the XRSound.dll is replaced I hear the poppings with DG and I don't hear them with my Cirrus-SR22.

I'm not sure I can reproduce this, maybe I can sometime hear a minute crack when mashing the button repeatedly but my keyboard is rather noisy and tends to cover things.
I guess it's the sudden change in volume that makes this happen since there is no smoothing applied . Do you also have it happen when toggling the engine on/off with the E key?
Edit : could reproduce clearly in the DG: set the thrust lever at ~10% and mash the + button.
Edit2 : new PR build with volume smoothing : https://github.com/TheGondos/orbiter/actions/runs/20679020087

 

[misha.physics]

Do you also have it happen when toggling the engine on/off with the E key?

No, on Cirrus-SR22 I hear it clearly during mashing the "+" button (engine must be enabled before by "E" key).

Edit : could reproduce clearly in the DG: set the thrust lever at ~10% and mash the + button.

Yes, I just reproduced it, I hear it. The same happens with Cirrus-SR22.

Edit2 : new PR build with volume smoothing : https://github.com/TheGondos/orbiter/actions/runs/20679020087

I tried the new XRSound.dll from your last link and now the poppings almost disappeared (both with DG and Cirrus-SR22). I still hear them (I check DG), but they became much less frequent (now they don't occur after every mashing the "+" key) and I turned up the volume to maximum to hear them.

Thank you for working on this. I just mentioned this issue in my Issues/Ideas list some times ago here:

There is an audible click after every thruster cut-off.

By the way, maybe you would like to have a look at other my points in that post. I'm open to testing and providing additional information.

 

[Gondos]

No, on Cirrus-SR22 I hear it clearly during mashing the "+" button (engine must be enabled before by "E" key).

Yes, I just reproduced it, I hear it. The same happens with Cirrus-SR22.

I tried the new XRSound.dll from your last link and now the poppings almost disappeared (both with DG and Cirrus-SR22). I still hear them (I check DG), but they became much less frequent (now they don't occur after every mashing the "+" key) and I turned up the volume to maximum to hear them.

Right now there are hardcoded magic values for the fading duration. I'm afraid there's no "one size fits all" value for this and there'll always be configurations where clicking occurs.

Thank you for working on this. I just mentioned this issue in my Issues/Ideas list some times ago here:

By the way, maybe you would like to have a look at other my points in that post. I'm open to testing and providing additional information.

Maybe with the new UI system, you can cross the Map MFD FPS drop issue?

 

[misha.physics]

Maybe with the new UI system, you can cross the Map MFD FPS drop issue?

It's already solved that. I don't notice any FPS droping both for Map MFD and Map window (durring dragging). Thanks again: