Discussion Proposal New version of Orbiter

Linguofreak

Well-known member
Joined
May 10, 2008
Messages
4,673
Reaction score
818
Points
138
Location
Dallas, TX
I wouldn't consider a PR tactless. Maybe annoying, if somebody sends you update after update for his PR and you barely have time to review it. But generally, a PR is a great opportunity to communicate. If you are maintainer, you can specify what you expect of the code, testers can give feedback about the improvements, etc. If people want to collaborate, the PR would be the last good chance to start with it. Sure, you can communicate earlier about what you plan. But nobody hates you for doing in the latest reasonable moment.

But generally, PRs are not more tactless than for example a draft for legislation. And like those, a PR rarely leaves "parliament" in the shape that it entered it. ;)

I was talking more about the communication surrounding the pull request than the code changes that made up the content of the pull request. My point was, if the GitHub comment thread for a PR (with working code) began with something like the OP here, it wouldn't be very tactful, but at least the person making the PR would be contributing code that worked towards what they were proposing, which isn't as tactless as just saying "Adopt this proposal I've drawn up without demonstrating any inkling of how much effort might be required, or any ability or willingness to contribute to that effort".
 
Last edited:

gamer19

Well-known member
Joined
Jul 16, 2016
Messages
161
Reaction score
235
Points
58
yeah, have to admit he was a bit rough around the edges 😁
maybe english wasn't his first language (like mine in case you didn't noticed😩) so he sounded harsher that intended ?
it does sound a bit weird if some bump into you out of the blue and "suggest" to do what he feels like needs to be done.
unless that's your boss of course

even more if you say that with something like "c'mon guys, let's do it ! you can do the 99% of the job and I may do the rest"
 

Urwumpe

Not funny anymore
Addon Developer
Donator
Joined
Feb 6, 2008
Messages
37,055
Reaction score
1,755
Points
203
Location
Langendernbach
I was talking more about the communication surrounding the pull request than the code changes that made up the content of the pull request. My point was, if the GitHub comment thread for a PR (with working code) began with something like the OP here, it wouldn't be very tactful, but at least the person making the PR would be contributing code that worked towards what they were proposing, which isn't be as tactless as just saying "Adopt this proposal I've drawn up without demonstrating any inkling of how much effort might be required, or any ability or willingness to contribute to that effort".

Yeah, that was a VERY bad way to make friends.
 

jameswebb

New member
Joined
Oct 30, 2022
Messages
11
Reaction score
16
Points
3
Location
usa
Wow! there are some seriously thin skinned people in here. taking my comments completely out of context. " i all but demanded changes ?" really? cant wait to see how you guys treat the next new idea. WoW! lol
 

Face

Well-known member
Orbiter Contributor
Addon Developer
Beta Tester
Joined
Mar 18, 2008
Messages
4,373
Reaction score
550
Points
153
Location
Vienna
Wow! there are some seriously thin skinned people in here. taking my comments completely out of context. " i all but demanded changes ?" really? cant wait to see how you guys treat the next new idea. WoW! lol
Sure. Welcome to yet another open-source project on the internet!
 
Top