GLS
Well-known member
Thanks for the new adapter! Could you provide the diameter at the IUS and Centaur ends (so I can add them to the manual to give payload developers the data to do other adapters)?
SSU Development Thread (3.0 to 4.0)
- Thread starter GLS
- Start date
GLS
Well-known member
That's what I'm doing now. I had some things already done, but I'm now putting it all together. It's not finished anyway, so I'll just leave those measurements as x.xxx for now.
---------- Post added at 03:55 AM ---------- Previous post was at 12:18 AM ----------
Ok, I finally finished the upper stage integration (just more content is missing from the manual, and I can't update the VS2013 projects so I'll have to leave that for who can).
Also, I want to give a heads-up on some files that were versioned in the IUS branch but were long gone from the trunk, but came back when the merge was gone.
This is of concern as these files are part of the default Orbiter installation and might have been overwritten and need replacement:
Textures\Exhaust_atsme.dds
(all files inside) Textures2\Atlantis\
I should have paid more attention, my apologies.
GLS
Well-known member
Urwumpe, when you have time could you look at the panel and panel group classes? I added a few new switches and found some kind of memory leak indication when closing the simulation. It was in the "scalar deleting destructor" of the panel, called from the panel group.
I eventually started to remove panels and it returned to normal. I then enabled all the panels again, and now the very same code that crashed works fine. :idk:
I eventually started to remove panels and it returned to normal. I then enabled all the panels again, and now the very same code that crashed works fine. :idk:
GLS
Well-known member
Nop... :facepalm: :facepalm:
GLS
Well-known member
A review is more of what I had in mind. Didn't you have some kind of tool to analyse the code?
Urwumpe
Not funny anymore
- Joined
- Feb 6, 2008
- Messages
- 38,965
- Reaction score
- 3,937
- Points
- 203
- Location
- Wolfsburg
- Preferred Pronouns
- Sire
Yeah, I remember something. Should I remember wrong, I just lint everything. :lol:
---------- Post added at 09:56 PM ---------- Previous post was at 04:35 PM ----------
25 issues with the code analysis of Visual Studio. Nothing related to the VC there. Most complain about how we use sscan_s, nothing serious.
There is an uninitialized memory issue in ssme.cpp which is pretty dire (bundle_power), also the bridgerail implementation in mission has a problem about array usage (A size of 13 means 12 is the highest legal index, not 12, a common C++ error).
I am a bit disappointed, because I know of more code smells, which we currently tolerate. Will look for a real tool.
GLS
Well-known member
The switches that caused the trouble are now committed. The problem didn't show itself again here. :shrug:
On the SSME.cpp bundle "issue", yes that could be a huge hole in the logic, but I did that (and still didn't change it) because the variable used by that switch is "controlled", i.e. that is not a problem unless we put 4 SSMEs in or the variable is overwritten or someone changes the SSME IDs to other than 1, 2 and 3. I can always change the last case to default to stop that warning.... and allow ID 4, 25 and 86. :lol:
I'll take a look at the bridgerails thing now.
---------- Post added at 01:10 AM ---------- Previous post was at 12:35 AM ----------
Fixed the bridgerail issue and added the payload adapter measurements to the manual.
Urwumpe
Not funny anymore
- Joined
- Feb 6, 2008
- Messages
- 38,965
- Reaction score
- 3,937
- Points
- 203
- Location
- Wolfsburg
- Preferred Pronouns
- Sire
I also did a check with cppcheck yesterday night, with some more issues. Most are about style(We use an earlier version of the language standard), nothing critical, but it also discovered some real issues in our code. Will fix the important ones and put the remaining issues as XML file into the source directory for reference.
GLS
Well-known member
Added engine gimballing to the upper stages, but it needs someone with vs2013 to add libUltra or it will only compile in vs2010.
Any news on the OrbitersimBeta branch? It was created by SiameseCat but there's no activity there.....
Any news on the OrbitersimBeta branch? It was created by SiameseCat but there's no activity there.....
GLS
Well-known member
Are you using the vs2010 projects? If so, then no changes should be needed as I updated those.
GLS
Well-known member
Bah, I was adding the library the wrong way. :facepalm: It was working as long as one didn't compile libUltra at the same time.... a fix will show up in a few minutes in the repository. Sorry!
---------- Post added at 05:38 PM ---------- Previous post was at 04:31 PM ----------
Took longer than I was expecting* but it should all work now. A full rebuilt should work with no problems.
*) I also fixed a problem with multi-core compilation (2 projects writting the same output file at once) by changing settings so intermediate files go to individual project folders. This also reduces the amount of "cra*" that shows up in the Modules folder.
Again this is just for vs2010, for 2013 someone else has to do it.
---------- Post added at 05:38 PM ---------- Previous post was at 04:31 PM ----------
Took longer than I was expecting* but it should all work now. A full rebuilt should work with no problems.
*) I also fixed a problem with multi-core compilation (2 projects writting the same output file at once) by changing settings so intermediate files go to individual project folders. This also reduces the amount of "cra*" that shows up in the Modules folder.
Again this is just for vs2010, for 2013 someone else has to do it.
GLS
Well-known member
And as Microsoft continues to downgrade their OSs, I might soon become a Linux user. Now that would be the perfect storm. :rofl:
Similar threads
- Locked
